ds2 was having milk with breakfast lunch and dinner (and then got sick and refused all milk since, but that's another story
) BUT i do think he was filling up on milk at breakfast and not eating much else.
ds1 at 18mths dropped milk with breaky, and just had a cup with lunch and dinner, and still does at 3.5yo, LOVES the stuff.
was more of a personal choice for me as i always remember having a cup of milk with dinner as a kid.
i know quite a few give milk with snacks tho when their LO wont drink enuf after a meal.
there's really no right or wrong, just whatever works for you both